Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chaining WM #1388

Merged
merged 34 commits into from
Apr 10, 2024
Merged

Chaining WM #1388

merged 34 commits into from
Apr 10, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Feb 15, 2024 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@Hitenjain14 Hitenjain14 linked an issue Feb 15, 2024 that may be closed by this pull request
Chain Writemarkers #1385
Open
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.67559% with 291 lines in your changes are missing coverage. Please review.

Project coverage is 14.92%. Comparing base (8329e36) to head (9bae8c6).

Files Patch % Lines
...de/go/0chain.net/blobbercore/writemarker/worker.go 0.00% 111 Missing ⚠️
...de/go/0chain.net/blobbercore/writemarker/entity.go 0.00% 65 Missing ⚠️
...et/blobbercore/handler/object_operation_handler.go 0.00% 39 Missing ⚠️
.../go/0chain.net/blobbercore/writemarker/protocol.go 0.00% 27 Missing ⚠️
.../0chain.net/blobbercore/handler/storage_handler.go 0.00% 9 Missing ⚠️
code/go/0chain.net/blobbercore/config/config.go 0.00% 6 Missing ⚠️
...o/0chain.net/blobbercore/handler/handler_common.go 0.00% 6 Missing ⚠️
.../0chain.net/blobbercore/writemarker/writemarker.go 0.00% 6 Missing ⚠️
...in.net/validatorcore/storage/writemarker/entity.go 50.00% 5 Missing and 1 partial ⚠️
...go/0chain.net/blobbercore/allocation/repository.go 0.00% 4 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@               Coverage Diff               @@
##           sprint-1.14    #1388      +/-   ##
===============================================
- Coverage        15.02%   14.92%   -0.11%     
===============================================
  Files              178      178              
  Lines            19922    20070     +148     
===============================================
+ Hits              2994     2996       +2     
- Misses           16556    16701     +145     
- Partials           372      373       +1
Flag Coverage Δ
Unit-Tests 14.92% <2.67%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hitenjain14 Hitenjain14 changed the base branch from sprint-1.13 to sprint-1.14 March 8, 2024 05:47
@Hitenjain14 Hitenjain14 marked this pull request as ready for review March 15, 2024 04:44
dabasov
dabasov approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit f1a24fd into sprint-1.14 Apr 10, 2024
6 checks passed
@dabasov dabasov deleted the feat/wm-chain branch April 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chain Writemarkers
3 participants
@Hitenjain14 @codecov-commenter @dabasov