Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from turndown-plugin-gfm to joplin-turndown-plugin-gfm (or any other maintained fork) #81

Open
alexanderadam opened this issue Feb 7, 2021 · 7 comments
Assignees

Comments

@alexanderadam
Copy link

The original plug-in is not maintained (last patch is from 3 years ago and PRs for bugfixes aren't merged) and it's not able to convert tables properly (see this or this).

But it seems that forks like joplin-turndown-plugin-gfm are well maintained and contain the bugfixes.
Maybe there's a better fork but CGUs switched to this one as well.

PS: As always thank you so much for copy-selection-as-markdown. I'm using it every day! 👍

@0x6b
Copy link
Owner

0x6b commented Apr 3, 2021

@alexanderadam Thank you for the suggestion. Really glad your feedback and it's totally my pleasure. The plugin you mentioned is really promising. I'll test it and get back to you (hopefully sooner but I have recently have limited bandwidth).

@0x6b 0x6b self-assigned this Apr 3, 2021
@alexanderadam
Copy link
Author

I'll test it and get back to you (hopefully sooner but I have recently have limited bandwidth).

No pressure. Take your time, stay healthy and enjoy time with your loved ones. Maintaining FOSS is no obligation. 😉

@alexanderadam
Copy link
Author

Now there's also another fork.
I don't know which one might be better, though. 🤷‍♂️

It'd probably be easier to have fixes in a single fork than distributed over many, but I'm not making the rules. 😞

@0x6b
Copy link
Owner

0x6b commented Jun 26, 2021

@alexanderadam Thanks for your patience and update for the issue. Newer fork looks good to me, as it might have a chance to merge into the original one. I'll compare these.

@alexanderadam
Copy link
Author

@alexanderadam it might have a chance to merge into the original one.

What makes you think that? 🤔

The old fork also has a PR ongoing… since 2018.

But the maintainer of the original project never merged it. I also asked the maintainer to explicitly mention at least, that the package isn't maintained.

@0x6b
Copy link
Owner

0x6b commented Jun 26, 2021

Ah I didn't know the mixmark-io/turndown-plugin-gfm#10. Now it's difficult to compare 🤔

@cebaa
Copy link

cebaa commented May 24, 2024

Just wondered if this is still on the radar. Not sure how big of an effort it would be to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@alexanderadam @0x6b @cebaa and others