Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: tag for extra transactions that would have been a good fit for the block; but we didn't know about #7

Open
0xB10C opened this issue May 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@0xB10C
Copy link
Owner

0xB10C commented May 7, 2021

No description provided.

@0xB10C 0xB10C added the enhancement New feature or request label May 7, 2021
@joostjager
Copy link

Do you mean transactions that showed up in a mined block that in retrospect would have been included in the template?

@0xB10C
Copy link
Owner Author

0xB10C commented Jun 7, 2023

Yes, for example, these three transactions right after the coinbase transaction in this AntPool block: https://miningpool.observer/template-and-block/000000000000000000006b45497499ba62079e4525a12ceda27f1b39b68697b5

If they would have been in my mempool at the time of building the template, my node would probably have included them. They were good candidates (in this case a good candidate-package).

image

@joostjager
Copy link

I think including them in the template would be valuable. It shows what the miner could have earned in fees given publicly available transactions and anything relayed to them in private.

But technically, I suppose it is difficult? You are using core's getblocktemplate, so when the block comes in, the template will change immediately and there is no opportunity anymore to see what the mempool would've looked like if the block txes were already known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants