Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Sugar for ._select #32

Open
2 tasks
0xMochan opened this issue May 31, 2023 · 0 comments
Open
2 tasks

Syntax Sugar for ._select #32

0xMochan opened this issue May 31, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@0xMochan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
._select is pretty verbose, especially when forced to use it with keywords like "from"

subgraph.Query.snapshots._select("from")

Describe the solution you'd like
Use the subscript helpers for a cleaner syntax (and more intuitive)!

subgraph.Query.snapshots["from"]

Implementation checklist

  • Add __setitem__ and __getitem__
  • Add tests for those!
@0xMochan 0xMochan added enhancement New feature or request good first issue Good for newcomers labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xMochan