From a341c4fb62327065a19b2f74e471c7f865551a45 Mon Sep 17 00:00:00 2001 From: Robin Salen Date: Tue, 24 Sep 2024 18:06:13 -0400 Subject: [PATCH] Comment --- evm_arithmetization/src/fixed_recursive_verifier.rs | 4 ++++ zero/src/bin/aggregator.rs | 4 ++-- zero/src/bin/aggregator/stdio.rs | 5 +++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/evm_arithmetization/src/fixed_recursive_verifier.rs b/evm_arithmetization/src/fixed_recursive_verifier.rs index 2c7aa12f8..6163dd025 100644 --- a/evm_arithmetization/src/fixed_recursive_verifier.rs +++ b/evm_arithmetization/src/fixed_recursive_verifier.rs @@ -108,6 +108,10 @@ where pub by_table: [RecursiveCircuitsForTable; NUM_TABLES], } +// TODO(Robin): This should be refactored in two distinct states, chain-specific +// (i.e. current `AllRecursiveCircuits` up to block circuit), and cross-chain +// specific (the 2-to-1 aggregation piece). +// cf: https://github.com/0xPolygonZero/zk_evm/issues/622 pub struct AllVerifierData where F: RichField + Extendable, diff --git a/zero/src/bin/aggregator.rs b/zero/src/bin/aggregator.rs index 6cde143da..29c6289d8 100644 --- a/zero/src/bin/aggregator.rs +++ b/zero/src/bin/aggregator.rs @@ -88,8 +88,8 @@ async fn main() -> Result<()> { stdio::stdio_aggregate(runtime, Arc::new(prover_config)).await? } } - Command::Rpc {} => todo!(), - Command::Http {} => todo!(), + Command::Rpc {} => todo!(), // TODO(Robin): Do we want to support RPC input source? + Command::Http {} => todo!(), // TODO(Robin): Do we want to support RPC input source? } Ok(()) diff --git a/zero/src/bin/aggregator/stdio.rs b/zero/src/bin/aggregator/stdio.rs index 112fb1da9..3cded499a 100644 --- a/zero/src/bin/aggregator/stdio.rs +++ b/zero/src/bin/aggregator/stdio.rs @@ -10,7 +10,8 @@ use zero::{ prover::ProverConfig, }; -/// The main function for the stdio mode. +// TODO(Robin): This should probably live in `leader` binary +/// Wrapping function for the stdio mode. pub(crate) async fn stdio_wrap( runtime: Arc, prover_config: Arc, @@ -65,7 +66,7 @@ pub(crate) async fn stdio_wrap( Ok(()) } -/// The main function for the stdio mode. +/// Aggregation function for the stdio mode. pub(crate) async fn stdio_aggregate( runtime: Arc, prover_config: Arc,