Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test data and coverage for trace decoder trie parsing and decoding #362

Closed
atanmarko opened this issue Jul 5, 2024 · 2 comments
Closed
Assignees
Labels
crate: trace_decoder Anything related to the trace_decoder crate.

Comments

@atanmarko
Copy link
Member

atanmarko commented Jul 5, 2024

Following previous discussions, we need to improve coverage of parsing and trie decoding.
It would mostly related to expanding and documenting test cases in the hermez_cdk_erigon.json and zero_jerigon.json files

@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Jul 5, 2024
@Nashtare Nashtare added the crate: trace_decoder Anything related to the trace_decoder crate. label Jul 5, 2024
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jul 8, 2024
@atanmarko atanmarko self-assigned this Jul 9, 2024
@atanmarko atanmarko changed the title Implement unit tests for trace decoder block witness parsing Improve test data and coverage for trace decoder trie parsing and decoding Jul 11, 2024
@Nashtare
Copy link
Collaborator

@atanmarko I would assume this is covered by #394?

@Nashtare Nashtare moved this from Backlog to In Progress in Zero EVM Jul 18, 2024
@atanmarko
Copy link
Member Author

Implemented with #394

@github-project-automation github-project-automation bot moved this from In Progress to Done in Zero EVM Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

No branches or pull requests

2 participants