-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do a pass on mpt_trie
#401
Comments
This is not accurate. We heavily use them when debugging trie discrepancies yielding |
I'm trying to remember the exact reason why I ended up adding the
Yeah give it a look, but two things:
|
Also just to clarify from the issue title, are you thinking about removing |
No, I think our trie library offers something unique that other libraries don't :) I just want to make it simpler if possible, c.f #400 |
cannot convert a slice of length 29 to FixedBytes<32>
with small data alloy-rs/trie#9 (comment), and then take it on.Remove the stats and debug modules - I don't think we use them.Arc<Node>
s everywhere - I'd prefer they were boxed, but we get a perf penalty in constructing dummy tries for our tests (I don't think this is a good reason)Nibbles
typeStandardTrie
types and traits c.f refactor: simplify mpt_trie's API #400The text was updated successfully, but these errors were encountered: