Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task - Setup GitHub Actions #10

Open
4 of 8 tasks
indifferentghost opened this issue Aug 19, 2021 · 4 comments · May be fixed by #103
Open
4 of 8 tasks

Task - Setup GitHub Actions #10

indifferentghost opened this issue Aug 19, 2021 · 4 comments · May be fixed by #103
Assignees
@bjorkypie @relspeedwagon @regromrob
Labels
infra This is functionality that directly interacts with the repository task A feature item

Comments

@indifferentghost
Copy link
Collaborator

indifferentghost commented Aug 19, 2021 •
edited by bjorkypie
Loading

  • GitHub Actions should run on every Pull Request

    • Run linting
      - [ ] Run testing
    • Attempt a build before merging

  • Github Actions is merged to main
    - [ ] Tests are run

    • Build
    • Should build into the "Staging" environment
    • Triggered by merging to main branch

  • GitHub Actions should have a Production Environment
    - [ ] Tests are run

    • Build
    • Should build into the "Production" environment
    • Manual release
@indifferentghost
Copy link
Collaborator Author

indifferentghost commented Aug 19, 2021 •
edited
Loading

This is blocked by Task - Client Setup (#5) and Task - Server Setup (#9)

@indifferentghost indifferentghost added blocked There's another issue that's blocking this task infra This is functionality that directly interacts with the repository task A feature item labels Aug 19, 2021
@indifferentghost indifferentghost removed the blocked There's another issue that's blocking this task label Aug 27, 2021
@indifferentghost
Copy link
Collaborator Author

Where are we on this?

@bjorkypie
Copy link
Collaborator

We can build the client package, but I believe we need to set environment variables in GitHub to build the server package.

Next is adding linting.

@bjorkypie
Copy link
Collaborator

Tried running linting with our own scripts, but didn't work because no files were staged, which is how scripts are currently set up. So we need to take a look at how to run the lint:fix and prettier independently.

Switched back to our scripts because marketplace script was looking at non-js files.

@bjorkypie bjorkypie linked a pull request Oct 24, 2021 that will close this issue
Open
@bjorkypie bjorkypie linked a pull request Oct 24, 2021 that will close this issue
GitHub actions #103
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorkypie bjorkypie

@relspeedwagon relspeedwagon

@regromrob regromrob

Labels
infra This is functionality that directly interacts with the repository task A feature item
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub actions 100devs/course-tracker
4 participants
@indifferentghost @bjorkypie @relspeedwagon @regromrob