Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week3 02-jwt function comment description inaccurate #456

Open
RageItalic opened this issue Dec 19, 2023 · 1 comment
Open

Week3 02-jwt function comment description inaccurate #456

RageItalic opened this issue Dec 19, 2023 · 1 comment

Comments

@RageItalic
Copy link

RageItalic commented Dec 19, 2023 •
edited
Loading

Small thing but in week-3/02-jwt/index.js the comment description for decodeJwt indicates the function is supposed to return an object or false. This is innacurate because based on the tests, the function is actually supposed to return true or false. Raising this since even though its a small issue, it can throw off students.
@kushvendar
Copy link

@RageItalic i am raising a pr for this
Screenshot 2023-12-20 at 9 17 14 AM

@kushvendar kushvendar mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RageItalic @kushvendar