Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug | OAuth tokens can be bigger than 255 characters #13505

Closed
stloyd opened this issue Jan 18, 2022 · 3 comments · May be fixed by 101medialab/Sylius#5
Closed

Bug | OAuth tokens can be bigger than 255 characters #13505

stloyd opened this issue Jan 18, 2022 · 3 comments · May be fixed by 101medialab/Sylius#5
Labels
Bug Confirmed bugs or bugfixes.

Comments

@stloyd
Copy link
Contributor

stloyd commented Jan 18, 2022

Sylius version affected: all

Description
OAuth tokens can be bigger than 255 characters, so database column cannot be simple varchar(255).

Steps to reproduce
Integrate i.e. LinkedIn OAuth.

Possible Solution
Change access_token & refresh_token fields to be bigger than than varchar(255).
@vvasiloi
Copy link
Contributor

For reference: https://docs.microsoft.com/en-us/linkedin/shared/authentication/authorization-code-flow?context=linkedin%2Fcontext&tabs=HTTPS#access-token-response

The length of access tokens is ~500 characters. We recommend that you plan for your application to handle tokens with length of at least 1000 characters to accommodate any future expansion plans. This applies to both access tokens and refresh tokens.

@vvasiloi vvasiloi added the Bug Confirmed bugs or bugfixes. label Jan 18, 2022
@TheMilek
Copy link
Member

Hi @stloyd 💃🏽
Could you please open PR with proper migration? 🚀

@timching timching mentioned this issue May 24, 2022
Draft
2 tasks
@timching timching mentioned this issue Jun 10, 2022
Closed
2 tasks
@NoResponseMate NoResponseMate mentioned this issue Mar 27, 2023
Merged
GSadee added a commit that referenced this issue Mar 30, 2023
@GSadee
refactor #14893 [OAuth] Up access and refresh tokens' length (NoRespo…
f31acc4 
…nseMate)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 |
| Bug fix?        | no                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets | fixes #11608 #13505, replaces #14072                      |
| License         | MIT                                                          |

Commits
-------

abb3cb7 [DX][OAuth] Up access and refresh tokens' length
@GSadee
Copy link
Member

GSadee commented Mar 30, 2023

Resolved by #14893

@GSadee GSadee closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase OAuth tokens size 101medialab/Sylius
Increase OAuth tokens size 101medialab/Sylius
4 participants
@stloyd @GSadee @vvasiloi @TheMilek