Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: PHP Notice: Function _load_textdomain_just_in_time was called incorrectly #4049

Open
1 task done
felipeelia opened this issue Dec 12, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working
Milestone

Comments

@felipeelia
Copy link
Member

Describe the bug

In #4036 we've delayed the load_plugin_textdomain call to the init action. Next, we must push some *__() calls to be done after that action.

That means that Feature and Indexable classes can not call i18n functions in their __construct methods, so we'll need to come up with a different way to set all labels and titles.

Steps to Reproduce

Using a different language in wp-admin and having WP_DEBUG on and no other plugin enabled, you should be able to see all the notices.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress and ElasticPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@felipeelia felipeelia added the bug Something isn't working label Dec 12, 2024
@felipeelia felipeelia added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant