-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/verify handling of post status changes #112
Comments
cc: @tlovett1 |
@adamsilverstein did #159 solve this? |
Yes, I think this is resolved although I haven't gone back to test. I'll try to to that soon and close. |
@adamsilverstein mind re-testing this to see if it can be closed? |
@adamsilverstein mind re-testing this to see if it can be closed? |
Testing results
verified
verified filter works as expected, added:
verified this
Verified.
verified no change in remote status. don't see it might be possible to achieve this with the
not in place as far as I can tell.
verified. post also becomes unlinked (editable) ResultsThe one thing missing is a |
I started work on addressing the final issue here in #446 |
I found a simple workaround to automatically trash posts on the receiving site that were trashed on the pushing site. It's possible since the permalink does update to "__trashed" correctly, just the post status doesn't. With this added to the receiving site's functions.php it does:
|
Thanks for this @TangramWerbeagentur! We're working to document and think through the various implications this has, especially as this inter-relates to distributing "as draft", to ensure we're considering all use cases and not negatively impacting a current use case with a PR on this topic. |
Updating post status
What happens when a post that has been distributed is published, or changed from published to draft (or moved to the trash)
Opening this issue to discuss the expected behavior when a post that has been distributed has it's post status changed.
Related: #107 & #110 & #159
Expected behavior
After some internal discussion, we have decided that the expected behavior for post status changes is as follows:
Distributing:
returning true from the. [Update] This was replaced by thedt_drafts_can_be_distributed
filterdistributable_post_statuses
filter.Updating:
dt_published_posts_distribute_status
filter. [Update 2023-11-29] The default behavior is that this is disabled/false.dt_published_posts_distribute_status
is set to true and an origin post status is changed from publish to any other status (a "takedown"), or any non published post is updated ("embargo lifted"), the statuses of distributed copies are updated to match. Status could be trash, private, draft, autodraft, future, pending, etc.Deleting
This post was distributed from [SITENAME]. However, the original has been deleted.
[Update 2023-11-29] This could be altered using the samedt_published_posts_distribute_status
set to true to similarly delete the remote posts, but this should be disabled/false by default.Connections
Remaining Todo after testing
Add a
dt_published_posts_distribute_status
filter to determine if a posts's status should be distributed along with other post data.The text was updated successfully, but these errors were encountered: