Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to a url that includes square brackets [] #201

Closed
jeffpaul opened this issue Jan 29, 2020 · 3 comments · Fixed by #330
Closed

Redirect to a url that includes square brackets [] #201

jeffpaul opened this issue Jan 29, 2020 · 3 comments · Fixed by #330
Assignees
Labels
help wanted type:bug Something isn’t working.
Milestone

Comments

@jeffpaul
Copy link
Member

Describe the bug
We received the following from @tbenyon on WordPress.ORG:

When saving square brackets in the Redirect To field they get html encoded.
For example, this:
/blog/?categories[]=*
. . . get turned into this:
/blog/?categories%5B%5D=*

This redirect does not work as wanted. This happens with REGEX enabled or disabled.

I’ve tried escaping the brackets with \ but that didn’t work.

Thanks,

Tom

Steps to Reproduce

See above

Expected behavior

Screenshots

Environment information

  • Device:
  • OS:
  • Browser and version:
  • Plugins and version:
  • Theme and version:
  • Other installed plugin(s) and version(s):

Additional context

@jeffpaul jeffpaul added type:bug Something isn’t working. help wanted labels Jan 29, 2020
@jeffpaul jeffpaul added this to the Future Release milestone Jan 29, 2020
@trainoasis
Copy link

trainoasis commented Jun 14, 2021

we have the same issue by using regex to match /. Escaping with \/ does not work. So basically Regex not working properly. Any workarounds? We are trying regex only because of the WPML related issue: #153. Using regex would be a useful workaround, but unfortunately without using slashes not very useful. Do let me know if I can help

@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Jun 28, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Jun 28, 2022
@jayedul jayedul self-assigned this Jun 26, 2023
@jayedul
Copy link
Contributor

jayedul commented Jun 26, 2023

It works anyway despite the square brackets get URL encoded. The data is available in the script. @jeffpaul Do we need to fix the visual representation of the parameters then?
Screenshot 2023-06-26 at 1 58 29 PM

@jayedul jayedul moved this from Backlog to In Review in Open Source Practice Jun 26, 2023
@jeffpaul
Copy link
Member Author

@jayedul could be worth fixing the visual representation as long as that doesn't impact functionality negatively

@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jun 30, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 2.1.0 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn’t working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants