Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust "Top Pages" in right hand column toggle #520

Open
tdlowden opened this issue Oct 16, 2018 · 2 comments
Open

Adjust "Top Pages" in right hand column toggle #520

tdlowden opened this issue Oct 16, 2018 · 2 comments
Assignees
Labels

Comments

@tdlowden
Copy link
Contributor

tdlowden commented Oct 16, 2018

When someone clicks on 7 days or 30 Days, the reports switch from being page-based (in the Now chart) to domain-based. Unfortunately, the language at the top of the chart that says Top Pages is currently static, no matter which chart a user is viewing. We need to alter the Top Pages heading on the chart to change to Top Sites or Top Domains when a user clicks 7 Days or 30 Days.
screen shot 2018-10-16 at 11 21 06 am
screen shot 2018-10-16 at 11 21 12 am

@lauraGgit
Copy link

Probably can't add a test to this unless we also build out headless browser testing, which would be ideal, but a big lift in addition to the unit tests I added in #531

@levinmr
Copy link
Contributor

levinmr commented Aug 19, 2024

This is still a thing that exists. @smarina04 is this something that we want to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants