Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require id just for possible endorsement #444

Closed
wants to merge 1 commit into from
Closed

Do not require id just for possible endorsement #444

wants to merge 1 commit into from

Conversation

amiller-ims
Copy link
Collaborator

@amiller-ims amiller-ims commented May 23, 2022 •
edited
Loading

The current data model requires the AchievementCredential, Achievement, and Profile classes have id property so they can be the subject (target) of an Endorsement.

This PR makes the id property of those 3 classes optional.

Closes #427, #428

@amiller-ims amiller-ims linked an issue May 23, 2022 that may be closed by this pull request
Achievement id #428
Open
@justinpitcher
Copy link
Contributor

Group agrees to keep id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3p0 candidate_final
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Achievement id AchievementCredential id
2 participants
@amiller-ims @justinpitcher