Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter hooks called without context #44

Open
mitchlloyd opened this issue Dec 21, 2016 · 0 comments · May be fixed by #48
Open

Adapter hooks called without context #44

mitchlloyd opened this issue Dec 21, 2016 · 0 comments · May be fixed by #48

Comments

@mitchlloyd
Copy link

Here 2 adapter hooks (keyForRelationship and keyForLink) are called without the adapter context. This makes it cumbersome to reuse logic that is on the consumer's adapter.

ember-data-hal-9000/addon/mixin.js

Lines 225 to 227 in e29064b

keyForRelationship = this.keyForRelationship,
keyForLink = this.keyForLink,
extractLink = this.extractLink,

makepanic added a commit to makepanic/ember-data-hal-9000 that referenced this issue Feb 14, 2017
@makepanic
Fix relationship extraction calling function without scope (201-creat…
bc7e449 
…ed#44)
@makepanic makepanic linked a pull request Feb 14, 2017 that will close this issue
Open
makepanic added a commit to makepanic/ember-data-hal-9000 that referenced this issue Feb 14, 2017
@makepanic
Fix relationship extraction calling function without scope (201-creat…
f8388cb 
…ed#44)

(cherry picked from commit bc7e449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix relationship extraction calling function without scope (#44) makepanic/ember-data-hal-9000
1 participant
@mitchlloyd