Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractRelationship extractId is called without passing the relationship modelClass #50

Open
makepanic opened this issue Feb 14, 2017 · 1 comment · May be fixed by #51
Open

extractRelationship extractId is called without passing the relationship modelClass #50

makepanic opened this issue Feb 14, 2017 · 1 comment · May be fixed by #51

Comments

@makepanic
Copy link
Contributor

I don't know if it's expected behavior but we have access to the relationship modelClass so why not pass it to extractId?

https://github.com/201-created/ember-data-hal-9000/blob/master/addon/mixin.js#L205
makepanic added a commit to makepanic/ember-data-hal-9000 that referenced this issue Feb 14, 2017
@makepanic
Fix extractRelationship extractId is called without passing the relat…
92f9e97 
…ionship modelClass (201-created#50)
@makepanic makepanic linked a pull request Feb 14, 2017 that will close this issue
Open
makepanic added a commit to makepanic/ember-data-hal-9000 that referenced this issue Feb 14, 2017
@makepanic
Fix extractRelationship extractId is called without passing the relat…
16a1b51 
…ionship modelClass (201-created#50)

(cherry picked from commit 92f9e97)
@Ramblurr
Copy link

Yup, I had to override the mixin function manually to get this. Would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ramblurr @makepanic