Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when validation doesn't actually run #206

Open
slimm609 opened this issue Nov 24, 2022 · 2 comments
Open

Fail when validation doesn't actually run #206

slimm609 opened this issue Nov 24, 2022 · 2 comments
Labels
bug small Small amount of work to implement

Comments

@slimm609
Copy link

When validating a file, if the schema or file doesn't actually exist, it still passes validation and returns an exit code of 0. If validation of an actual file fails then the exit code is 1. This is a similar behavior that would be expected for invalid files or missing files.

If the schema file doesn't exist or the number of matching yaml files is 0, then the exit code should probably be 1.

yamale -s not-a-schema not-a-file
Finding yaml files...
Found 0 yaml files.
Validating...
Validation success! 👍
@cblakkan cblakkan added bug small Small amount of work to implement labels Nov 24, 2022
@cblakkan
Copy link
Member

Agreed, this should be fixed.

I can't give you a timeline right now for when we might get to this. We do accept pull requests if you'd like to submit a fix though :)

@Andres-Ventura
Copy link

Andres-Ventura commented Feb 19, 2023

Let me work on this. Assign it to me please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug small Small amount of work to implement
Projects
None yet
Development

No branches or pull requests

3 participants