-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to exclude subdomains #8301
Comments
If you're interested in why and when that started, it began in March and was announced earlier this year. There is also a help center article on it.
You could create a no-MFA entry for Do you happen to know if they all loan servicers share credentials? I would imagine no, but it is possible. They all share the same routes and login/signup pages, albeit with different styles.
This is definitely something we can look into. Off the top of my head, it would likely be similar to the regions array where excluded regions are prefixed with a {
"Federal Student Aid": {
"domain": "studentaid.gov",
"additional-domains": [
"-nelnet.studentaid.gov",
"-aidvantage.studentaid.gov",
]
}
} It would be up to password managers to support this though.
We currently use the root domain ranking because Similarweb does not usually rank subdomains. See #8186 for more detail. |
Done for Nelnet and Aidvantage in #8312 👍
Doesn't look like it. Nelnet and Aidvantage do not share creds with each other at least (nor with the federal studentaid.gov site).
Assuming the above PR works the way we think it will, then I guess my use case is already solved. I leave it up to you maintainers decide if "excluded domains" are worth implementing. 🤷♂️ (If not then feel free to close this Issue) |
Information about the feature to be added:
There may already be a way to do what I'm trying to do, I just couldn't figure it out from the CONTRIBUTING docs. My use case is for Student Loan servicers. It looks like all servicers are now required to host their sites on subdomains of
studentaid.gov
, e.g. <nelnet.studentaid.gov> and <aidvantage.studentaid.gov>. The Federal Student Aid website hosted at <studentaid.gov> does support 2FA, but not all of these servicer-specific subdomains do. Thus, password managers like 1Password will recommend setting up 2FA on these sites, but it's impossible to actually do so (Nelnet and Aidvantage are both examples of this). It would be great if there was a way to exclude thenelnet
andaidvantage
subdomains (and any others) from thestudentaid.gov.json
file.Following the discussion on #3835:
1Password does allow specifying different "autofill behaviors" though, including "Only fill on this exact domain". So one could have separate Login items for
studentaid.gov
and every relevant*.studentaid.gov
, each with that behavior set. Ideally, the root domain item would suggest enabling 2FA, while the subdomain items would not. Presumably, other password managers could work similarly.In the specific case of student loan servicers, I think you could treat their sites' rankings as equivalent to
studentaid.gov
. Idk if you'd want to use the root domain ranking for all sites though...The text was updated successfully, but these errors were encountered: