-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: prevent vertical dragging #44
Comments
having same issue. |
I see the problem! This, however, is a hard one to solve because even if we implement so that the cards won't accept vertical dragging the event will already have been triggered and therefore it will still prevent the user from scrolling. And even if you would send back the drag then it would make the code complicated since a ref would need to be used to push props upstream. Perhaps you could solve it by making a div on top of the cardstack and intercepting drag events and only passing them through when they do not start dragging downwards however this will likely cause a lot of other issues. The best way to solve this would probably be to make the card swipe a horizontal scroll area all together but that would require a completely different approach than this module uses. Do you have any proposed way of implementing this? |
Perhaps changes could be made to the prevent.default on the touchStart event as mentioned here. Setting that dynamically depending on what direction the finger is headed could be a solution. |
Is there any solution for this? I wonder it too. |
Thanks for this suggestion @3DJakob ! I'll fork this repo and try it out. |
@anonimitoraf did you mange to fix this? |
need to able to scroll vertically, any solution? |
I would appreciate a solution here too. This seems to be an important area of improvement. |
Imagin we have a cards that fulfill most of the mobile display area. In that case we have not a chance to scroll page up / down becasue instead of scrolling the page you can only swipe the card. It would be greate to have an ability to prevent vertical dragging.
The text was updated successfully, but these errors were encountered: