Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2D MVP] Milestone 5: set vertical limits on new drawing #5173

Closed
4 tasks
sanmont3drepo opened this issue Sep 24, 2024 · 2 comments
Closed
4 tasks

[2D MVP] Milestone 5: set vertical limits on new drawing #5173

sanmont3drepo opened this issue Sep 24, 2024 · 2 comments

Comments

@sanmont3drepo
Copy link
Contributor

Description

Product issue: https://github.com/3drepo/3D-Repo-Product-Team/issues/594
Autocalibration works by using GIS coordinates to set the calibration vectors only in the ground plane. For managing the vertical boundary the user must enter it. For providing a framework so autocalibration can work we'll let the user set the

Goals

  • As a user I want to be able to calibrate a drawing with the least amount of data provided from my end

Tasks

  • Add "bottom extent" and "top extent" fields to the new drawing form
  • Add "bottom extent" and "top extent" fields to the settings form
  • Add "bottom extent" and "top extent" fields to the sidebar form when uploading a file (should it be readonly @carmenfan when is an already existing drawing?)

Related Resources

@carmenfan
Copy link
Member

Add "bottom extent" and "top extent" fields to the sidebar form when uploading a file (should it be readonly @carmenfan when is an already existing drawing?)

Should behave the same way as other values within drawing settings, if they're read only then it should be read only

Amantini1997 added a commit that referenced this issue Sep 27, 2024
Amantini1997 added a commit that referenced this issue Sep 27, 2024
Amantini1997 added a commit that referenced this issue Sep 27, 2024
Amantini1997 added a commit that referenced this issue Oct 2, 2024
Amantini1997 added a commit that referenced this issue Oct 2, 2024
Amantini1997 added a commit that referenced this issue Oct 2, 2024
@carmenfan
Copy link
Member

merged into #5038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants