Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model uploads should not be resetting the incomplete flag in between phases #588

Open
carmenfan opened this issue Jul 29, 2022 · 0 comments

Comments

@carmenfan
Copy link
Member

Description

currently, after each stage of processing, we reset the incomplete flag.

This causes a situation where if the process timeout/crash in a specific timing, the revision will look like it has been processed successfully.

We should stop resetting the flag in between to ensure this doesn't happen

Steps to replicate

  • upload a model
  • force the process to exit in between process

Current Behaviour

  • it will return failure, but the user will be able to see a revision uploaded in the revision API

Expected Behaviour

  • the user should not be able to see the revision as a valid revision
@carmenfan carmenfan added the bug label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant