Autodesk 2024 native support (ODA upgrade)

[carmenfan]

No description provided.

[sebjf]

Things that changed this time round:

1. BmViewType Enum has changed location
2. The ParamDef Group Type has changed type
3. The flags for the type of geometry in an OdNwFragment have been removed (the geometry itself must now be tested by casting to the different subclasses)
4. The way the vertex data in an OdNwGeometry is accessed has changed.

Things to check extra carefully:

1. That the built in parameter labels are correct
2. That the view setup in RVT is still correct
3. That both Lines and Meshes still import correctly from Navisworks

[sebjf]

Hi @carmenfan, on staging, the Source File key contains the full filename for a Navisworks entry...

This line suggests that we intend to only include the filename itself:

3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/import/odaHelper/data_processor_nwd.cpp

Line 259 in 15045ef

setMetadataValue(OD_T("Item"), OD_T("Source File"), ItemSourceFile.filename().string(), metadata);

However, given the import I just performed, it seems this is not taking effect.

Do you know what the desired behaviour is? (I.e. whether the Source File metadata entry should display the full path or just the filename?)

[carmenfan]

Hi @carmenfan, on staging, the Source File key contains the full filename for a Navisworks entry...

This line suggests that we intend to only include the filename itself:

3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/import/odaHelper/data_processor_nwd.cpp

Line 259 in 15045ef

setMetadataValue(OD_T("Item"), OD_T("Source File"), ItemSourceFile.filename().string(), metadata);

However, given the import I just performed, it seems this is not taking effect.

Do you know what the desired behaviour is? (I.e. whether the Source File metadata entry should display the full path or just the filename?)

@sebjf
I think we only want the file name here, afterall the path to the file isn't very useful in the cloud aimed for collaboration!

[sebjf]

Differences accounted for:

1. Some display names have more information, e.g. an entry called 327598 is now called Model Lines_327598.
2. OdNwPartition::getDisplayName now includes the file path; bouncer has been updated to remove it when setting the layer, as this would affect the tree.
3. The Item::Material metadata entry has different Color values. These are internal implementation details so no change is necessary.
4. Two new items, Item::Source File Name and Item::File Name have been added, both of which include the full path. The metadata also sometimes includes Item::Source File too. A post-processing stage removes the path from the filename for all of these. Item::Source File is added explicitly based on the partition if not set elsewise. Item::Source File Name is ignored, since without the path it is identical to Item::Source File.
5. The unicode characters for some units have changed (they both displayed correctly before in Chrome, but the new ones are "more correct").
6. Some coordinates (e.g. Constraints::Colum Location Mark) are swapped (so, B.1-.5 becomes .5-B.1). This is an ODA implementation detail/we don't touch this directly in bouncer.