Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

Commit dialogue's database isnt updated as expected #121

Open
carmenfan opened this issue Jan 20, 2016 · 1 comment
Open

Commit dialogue's database isnt updated as expected #121

carmenfan opened this issue Jan 20, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@carmenfan
Copy link
Member

If you try to commit a model while the databases are still loading on the repository tree widget, it will populate the list of databases available as of the moment you clicked the commit dialog -> i.e. databases that aren't loaded within the repository tree will not be shown. Which is fair enough.

But once the repository tree widget has been fully loaded (with the commit dialog still active), you still cannot select a database that wasn't loaded at the point of commit dialogue was triggered -> i.e. the the database list isn't refreshed with the latest available cache.

I would think that the natural human expectation would be that if you click on the drop down menu to select a database, the database list would be updated if there are more databases found since the point commit dialogue was triggered .

Should it not be sharing the same cache everywhere? are we copying the repoIDCache around?

@carmenfan carmenfan added the bug label Jan 20, 2016
@carmenfan carmenfan added this to the 1.0 Beta milestone Jan 20, 2016
@jozefdobos
Copy link
Member

It does share the cache as a pointer as you would expect, however, the dropdown is populated on commit dialog constructor. In other words, there is no event to trigger that the cache has been updated. I agree, this needs to happen, but as a part of the overall DB tree rewrite.

@jozefdobos jozefdobos self-assigned this Jan 20, 2016
@carmenfan carmenfan modified the milestones: 1.0 Beta, Next Release Mar 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants