Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge algorithm breaks topology when opposite of h2 next is the previous of the opposite of h1 #25

Open
sebjf opened this issue May 12, 2023 · 0 comments

Comments

@sebjf
Copy link

sebjf commented May 12, 2023

The Merge algorithm fails in a topological edge case, when the opposite halfedge of the next halfedge of h1 is the same as the previous halfedge of the opposite halfedge of h1.

I.e,
prev(opposite(h1)) == opposite(next(h2))

The counter clockwise navigation around a vertex, moves first to the previous edge, and then to the opposite. When the above case is true, it creates a 'short cut' creating phantom patches again.

As a workaround, this case can be detected in the Merge filtering stage, but we should identify what is going on properly and see if the edges can be merged without breaking the topology instead of just ignoring the pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant