Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian priors for limb-darkening #84

Open
sgongar opened this issue Oct 1, 2021 · 3 comments
Open

Gaussian priors for limb-darkening #84

sgongar opened this issue Oct 1, 2021 · 3 comments
Assignees

Comments

@sgongar
Copy link

sgongar commented Oct 1, 2021

Is there any chance of implement gaussian priors (apart of boundaries) for limb-darkenings?

@3fon3fonov
Copy link
Owner

Since the LD parameters are generally poorly determined, I only added bounds between 0 to 1. I am not sure why one would adopt different than a flat prior for these parameters, but OK, for consistency, I will add the gaussian/Jefferey priors.

However, this may take some time because it is a lengthy job to add all these in the GUI. I will try to do it in the next 2-3 weeks.

@3fon3fonov 3fon3fonov self-assigned this Oct 3, 2021
@3fon3fonov
Copy link
Owner

I included the Gaussian and Jefferey priors of the LD parameters.

test_gauss_jeff_LD_priors

However, these are still not exportable to the GUI, when a session is loaded.... I will need some more time to make this fix. Can you please, first confirm that the GUI loads correctly the priors?

@sgongar
Copy link
Author

sgongar commented Oct 7, 2021

Yes! the GUI works as expected, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants