Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "dispaly info" in attribute table show nothing if field used for primary key is not part of WMS/WFS capabilities #3674

Closed
1 task
gioman opened this issue May 7, 2023 · 6 comments
Labels

Comments

@gioman
Copy link
Contributor

gioman commented May 7, 2023

What is the bug?

In the attribute table of a layer (that has the "popup" option active), the "display info" panel is empty

image

Steps to reproduce the issue

Publish a layer in LMWC with the popup option active, and also with the attribute table available.

Open the table, select a record/feature and click on "display info" icon.

Versions

QGIS LTR on Server and Desktop, Latest version of LMWC, LM plugin and LM server plugin

Check Lizmap plugin

  • I have done the step just before in the Lizmap QGIS desktop plugin before opening this ticket. Otherwise, my ticket is not considered valid and might get closed.

QGIS server version, only if the section above doesn't mention the QGIS Server version

3.28

Operating system

Ubuntu 22.04, desktop and server

Browsers

Firefox, Chrome

Browsers version

Latest

Relevant log output

No response

@gioman gioman added the bug label May 7, 2023
@Antoviscomi
Copy link
Contributor

Antoviscomi commented May 8, 2023

@gioman
in my LWC 3.6.3 on ubuntu 22.04 all seems works fine
Schermata del 2023-05-08 13-56-02
both with or without selection on attribute table
Schermata del 2023-05-08 13-58-15

@gioman
Copy link
Contributor Author

gioman commented May 8, 2023

in my LWC 3.6.3 on ubuntu 22.04 all seems works fine

@Antoviscomi I have the same setup, and here is not working. Maybe is something project specific. I'm happy to let someone have a look if necessary.

@gioman
Copy link
Contributor Author

gioman commented May 8, 2023

Found the reason: a field that is excluded from the WMS/WFS capabilities then should not be used as "primary key" in LM plugin when it comes to te configs for a layer attribute table.

I think that fields that are excluded from the WMS/WFS capabilities should not be shown at all in Lizmap plugin... feel free to move this to the LM plugin tracker, as suggestion for improvement.

@gioman gioman changed the title [Bug]: "dispaly info" in attribute table show nothing [Bug]: "dispaly info" in attribute table show nothing if field used for primary key is not part of WMS/WFS capabilities May 8, 2023
@Gustry
Copy link
Member

Gustry commented May 9, 2023

I think that fields that are excluded from the WMS/WFS capabilities should not be shown at all in Lizmap plugin... feel free to move this to the LM plugin tracker, as suggestion for improvement.

This is true, but there are already many caveats, options, and mutually exclusive rules.

For instance,

  • the user can set all options in Lizmap plugin,
  • hide some fields from WFS, WMS capabilities which were used in the Lizmap configuration,
  • what would happen to the previous configuration ? There should be again some warnings.

We have a long list of checks we would like to do when saving the CFG file : 3liz/lizmap-plugin#389

As Lizmap is coming after the request to QGIS server, a lof of things are broken if some fields are not in the data sent by QGIS server to LWC, not only "display info" : the dataviz, the form filtering, time manager ... everywhere where the plugin is asking for a field.

@Gustry Gustry closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
@gioman
Copy link
Contributor Author

gioman commented May 9, 2023

@Gustry fair enough. I think anyway that a small mouseover warning in the plugin could help the users: "do not use for primery key a field that is excluded from WMS/WFS capabilities".

@Gustry
Copy link
Member

Gustry commented May 9, 2023

I added it in the ticket #389 already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants