Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamps in transactions can blindly take invalid input #170

Open
unleashed opened this issue Mar 16, 2020 · 0 comments
Open

timestamps in transactions can blindly take invalid input #170

unleashed opened this issue Mar 16, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@unleashed
Copy link
Contributor

The usage of Date._parse when taking the input of the timestamp field of transactions is insufficient to validate a date. In particular, it's been discovered that some strings with a specific number of digits are considered dates by the affected code.

Note that the documentation only talks about a specific format for dates in the timestamp field, so for example we might want to consider changing this so proper validation happens as specified in the docs.

@unleashed unleashed added the bug Something isn't working label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant