Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hope to update documents #1

Open
feg545 opened this issue Dec 16, 2019 · 4 comments
Open

hope to update documents #1

feg545 opened this issue Dec 16, 2019 · 4 comments

Comments

@feg545
Copy link

feg545 commented Dec 16, 2019

Dear author,
seems like this is the most popular Jenkins image with docker in docker, thank you very much!
I found some issues when trailing your image, hope you can consider them:

  1. will meet the 'Permission Denied' issue. since the /var/run/docker.sock in the host, is only allows root user/docker group to access, but this image will use Jenkins user in the container, so I would like to run with --user 0 to simply avoid this issue, any better idea?

  2. suggest adding volume: /etc/docker. then we can use the same certs.d fold and daemon.json as the host machine. although we can manually mount any path into a Docker container, this is still a hint for some docker management UI to create a volume (like Portainer).

  3. It would be nice to give a Jenkins Pipeline example to build a docker image.

@4OH4
Copy link
Owner

4OH4 commented Dec 23, 2019

Thanks for the feedback. To your points:

  1. I didn't get that error myself. Running as root all the time isn't the ideal option though, in my opinion. One approach would be to specify the user as arguments - that might add some flexibility?
  2. That looks like a good idea, I'll have a look in to that. You are welcome to submit a pull request if you'd like to be a contributor.
  3. Yes - that is on my list of things to write. Hopefully over the holiday season I will find a day or so to put that together.

@christianlupus
Copy link
Contributor

I think the first issue here is solved by PR #3. Then you can run with user jenkings and nevertheless access docker from the host. @4OH4 what do you think?

@4OH4
Copy link
Owner

4OH4 commented Feb 12, 2020

Sorry for dragging my feet a bit on PR #3 - other commitments keeping me away and have been trying to garner some opinons on good practice here.

I'm conscious of adding layers of complexity to patch an issue with the underlying method. That said, the entrypoint script method seems quite neat. Do you see any potential downsides?

@christianlupus
Copy link
Contributor

I will shift the discussion into the PR as I do not want to hiccup this issue right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants