From 4f22f5a9fc430c10ab813537ba9d4f0208ccc5e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Pasteau?= <4895034+ClementPasteau@users.noreply.github.com> Date: Mon, 27 Nov 2023 18:31:57 +0100 Subject: [PATCH] Fix possible undefined iconFileName --- .../InstructionEditor/InstructionParametersEditor.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js b/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js index 8c98688fa5ce..e656f53f778d 100644 --- a/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js +++ b/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js @@ -237,7 +237,8 @@ const InstructionParametersEditor = React.forwardRef< objectName ); - const iconFilename = instructionMetadata.getIconFilename(); + // For some reason, iconFileName can sometimes be undefined. see https://github.com/4ian/GDevelop/issues/5958. + const iconFilename = instructionMetadata.getIconFilename() || ''; const shouldInvertGrayScale = paletteType === 'dark' && (iconFilename.startsWith('data:image/svg+xml') || @@ -251,7 +252,7 @@ const InstructionParametersEditor = React.forwardRef<