Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision not working after deleting frame #5541

Closed
1 task done
VegeTato opened this issue Aug 6, 2023 · 2 comments
Closed
1 task done

Collision not working after deleting frame #5541

VegeTato opened this issue Aug 6, 2023 · 2 comments

Comments

@VegeTato
Copy link
Contributor

VegeTato commented Aug 6, 2023

Is there an existing issue for this?

Describe the bug

As the title says, The collision does not work after deleting the sprite Frame and leave the animation empty.
It shows an empty collision mask.

Steps (uploading video is not possible as the size limit in here is so tiny for any video):
1- Create new sprite
2- Add asset from hard drive
3- open collision editor
4- Use custom collision mask
5- edit the mask a lil bit
1-402
6- Right-click on the animation frame and select (Delete selection:
2-527
7- Add the asset again
8- The new collision mask will be completely wrong
3-719

Now this sprite is bugged forever, even if you removed the entire animation (not just the frame) and hit apply
and then open that sprite and add another asset, it will always get the same wrong collision showing in the SS above

Steps to reproduce

Mentioned in the description.

GDevelop platform

Desktop

GDevelop version

Latest

Platform info

No response

Additional context

No response

@ClementPasteau
Copy link
Collaborator

Thanks for reporting @VegeTato

Actually, this is not a new behavior, it's always been like this.
The collision masks are unique per image, meaning that if you delete all the images of a sprite, then you are losing the custom collision mask you've created. (even if the checkbox "share same collision mask" is ticked)
We will improve the interface to warn when deleting the last frame.

If you want to keep you mask, you need to either create a new frame or a new animation before deleting this one.

@VegeTato
Copy link
Contributor Author

VegeTato commented Aug 7, 2023

Thanks for reporting @VegeTato

Actually, this is not a new behavior, it's always been like this. The collision masks are unique per image, meaning that if you delete all the images of a sprite, then you are losing the custom collision mask you've created. (even if the checkbox "share same collision mask" is ticked) We will improve the interface to warn when deleting the last frame.

If you want to keep you mask, you need to either create a new frame or a new animation before deleting this one.

Oh, I understood, thanks for explaining ❤️

@VegeTato VegeTato closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants