Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll Events Sheet while doing a search #5638

Open
1 task done
ClementPasteau opened this issue Sep 7, 2023 · 0 comments
Open
1 task done

Cannot scroll Events Sheet while doing a search #5638

ClementPasteau opened this issue Sep 7, 2023 · 0 comments
Labels
🐛 bug This is a bug impacting users

Comments

@ClementPasteau
Copy link
Collaborator

Is there an existing issue for this?

Describe the bug

When a search is initiated in the Events Sheet, scrolling with the mouse becomes impossible.

Steps to reproduce

  1. Open platformer example
  2. Open Events Sheet
  3. Hit CTRL+F and Search for "camera"
  4. After the result is highlighted, try to scroll down
  5. The sheet keeps scrolling back up

GDevelop platform

Desktop, Web, Mobile

GDevelop version

5.2.172

Platform info

No response

Additional context

After a bit of investigation, this seems to be coming from the searchFocusOffset property of react-sortable-tree.
This property is set correctly to focus the right search result, however it seems like when it is set we cannot scroll anymore.
An idea could be to remove this prop and do the scrolling ourselves. (in EventsSearcher, rework the _goToSearchResults to do a scrollToRow()

@ClementPasteau ClementPasteau added the 🐛 bug This is a bug impacting users label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug impacting users
Projects
None yet
Development

No branches or pull requests

1 participant