Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Improve Java client class implementation #36

Open
nuest opened this issue Oct 23, 2013 · 2 comments
Open

Improve Java client class implementation #36

nuest opened this issue Oct 23, 2013 · 2 comments

Comments

@nuest
Copy link
Contributor

nuest commented Oct 23, 2013

The class https://github.com/52North/GEO-label-java/blob/master/client/src/main/java/org/n52/geolabel/client/GeoLabelClientV1.java can be improved so that other users can easily create labels in their Java applications by providing more shortcut methods. Also the URL must be editable (bug).

  • remove static URL
  • default URL must be configured in constructur (inserted with Guice? from config file?)
  • add convenience method createGeoLabelGetUrl(String feedbackUrl)
  • add convenience method createGeoLabelGetUrl(String metadataUrl, String feedbackUrl)
  • add convenience method createGeoLabelRequest(String metadataUrl, String feedbackUrl)
@hopmann
Copy link
Contributor

hopmann commented Oct 23, 2013

The URL is editable, see all createGeoLabelRequest methods. The static URL is the default Service URL.

@nuest
Copy link
Contributor Author

nuest commented Oct 23, 2013

sorry, my bad - the default should not be set as a static variable though ;-).

@ghost ghost assigned hopmann Nov 20, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants