Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ComparisonFilter.java #9

Open
autermann opened this issue Jan 8, 2018 · 1 comment
Open

Refactor ComparisonFilter.java #9

autermann opened this issue Jan 8, 2018 · 1 comment
Labels
discussion enhancement help wanted shetland

Comments

@autermann
Copy link
Member

The class ComparisonFilter.java must be refactored since it currently provides to many constructors and setters to be easily manageable. This has considerable impact on the decoders which currently take advantage of the loose available methods.

See discussion at 52North/iceland#36 (comment)

Better approaches on the table so far:

  • static factory methods and a single private constructor
  • new fluent API

See 52North/iceland#37.
@autermann autermann mentioned this issue Jan 8, 2018
Closed
@aakarshvats638
Copy link

Sir I would like to work on this issue ,can you please elaborate what i have to do? @autermann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement help wanted shetland
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@autermann @aakarshvats638