Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code / repository organization improvements : remove rt-xr-maf-plugin #5

Open
nlsdvl opened this issue Aug 30, 2023 · 4 comments
Open
Labels
help wanted Extra attention is needed

Comments

@nlsdvl
Copy link
Contributor

nlsdvl commented Aug 30, 2023

The unity player implementation currently comes as a set of 4 repos:

  1. rt-xr-unity : reference player - unity project
  2. rt-xr-gltfast : a fork of glTFast - unity plugin
  3. rt-xr-maf-plugin : maf library & media pipelines - unity plugin.
  4. rt-xr-maf-native : maf library & media pipelines - C++ libraries

This configuration makes the project more complex to maintain and reason about than it has to be.

Having fewer repos would make it easier:

  • Most C# scripts in repo Hosting of the sample content #1 should be moved to be distributed through a unity package, not as project scripts.
  • It seems the glTFast project has now become an official Unity package.
    All code related to parsing iso-23090-14 can be moved to the gltfast fork. But code related to a generic xr player implementation might not be relevant there.
  • rt-xr-maf-plugin was initially intended to contain the maf implementation for unity. It currently only contains build artifacts and dependencies from rt-xr-maf-native. If media player code wrapping the MAF API for Unity is not maintained in this repo, it could be removed.

The project needs to be organized with the following in mind:

  • the reference unity project should be buildable using Unity cloud build
  • the code should be bundled as a unity package to be easily re-usable in custom unity projects
@nlsdvl nlsdvl changed the title Move player scripts to a unity package Move player C# scripts to a unity package Aug 31, 2023
@dsilhavy dsilhavy added this to the Version 1.0.0 milestone Sep 7, 2023
@nlsdvl nlsdvl changed the title Move player C# scripts to a unity package code / repository organization improvements Nov 21, 2023
@nlsdvl nlsdvl moved this from Todo to Backlog in XR: XR Player ISO/IEC 23090-14 support Feb 9, 2024
@nlsdvl nlsdvl added help wanted Extra attention is needed documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 13, 2024
@nlsdvl nlsdvl changed the title code / repository organization improvements code / repository organization improvements : remove rt-xr-maf-plugin Feb 13, 2024
@nlsdvl
Copy link
Contributor Author

nlsdvl commented Feb 13, 2024

rt-xr-maf-plugin is really just a build artifact of rt-xr-maf-native and there is no plan to add extra code or features there.
I propose to remove it. continuous delivery of rt-xr-maf-native and updated documentation should reduce the friction for new developpers.
cc @Etiennefaivredarcier @aaronmontilla

@Etiennefaivredarcier
Copy link

I agree on this, the number of repositories need to be reduced to invite new developers to test the tools

@aaronmontilla
Copy link

I completely agree with you, it was difficult for me to understand what each repository was used for. Reducing the number of repositories will make the first steps more intuitive for beginners.

@nlsdvl nlsdvl moved this from Todo to In Progress in XR: XR Player ISO/IEC 23090-14 support Mar 8, 2024
@nlsdvl nlsdvl moved this from In Progress to Todo in XR: XR Player ISO/IEC 23090-14 support Mar 8, 2024
@nlsdvl nlsdvl moved this from Todo to In Progress in XR: XR Player ISO/IEC 23090-14 support Mar 15, 2024
@nlsdvl
Copy link
Contributor Author

nlsdvl commented Mar 15, 2024

Progress on continous delivery for the media pipeline dependencies here: 5G-MAG/rt-xr-maf-native#6

@nlsdvl nlsdvl moved this from In Progress to Todo in XR: XR Player ISO/IEC 23090-14 support Apr 12, 2024
@nlsdvl nlsdvl removed this from the Version 1.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

4 participants