Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File structure #47

Open
gomorizsolt opened this issue Sep 17, 2018 · 2 comments
Open

File structure #47

gomorizsolt opened this issue Sep 17, 2018 · 2 comments
Labels
question Further information is requested

Comments

@gomorizsolt
Copy link
Collaborator

I've submitted this issue in the PoE Dashboard repo, but IMO it's important to talk about here as well.
I think we have to create a better file structure, or what do you think?

@gomorizsolt gomorizsolt added the question Further information is requested label Sep 17, 2018
@Kexort
Copy link
Collaborator

Kexort commented Sep 17, 2018

As mentioned here: https://reactjs.org/docs/faq-structure.html

don’t spend more than five minutes on choosing a file structure

I think the best course is to follow the "Grouping by features or routes" convention.
In this project we doesn't have routes (yet?), so let's group by features.

This is for the 'src' folder. Other than that assets should go to the public folder.

How about this? (This is just a suggestion, you can propose something if you find that better)

I think this project won't grow much larger to cause us problems, but it's a valid concern about the dasboard.
If you want to use the same structure for the two projects i'm also ok with it :)

@gomorizsolt
Copy link
Collaborator Author

"Grouping by features or routes" - I like it. I think we can go on this way and will see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants