-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIleInput from memory #144
Comments
In current design files are only read from filesystem. File uploads from in-memory sounds like a good feature to add. |
@64bit I am looking for the ability to add audio data vecs to AudioInput instead of having to write them to a file first, would this be something you'd be interested in a PR for? |
Absolutely interested!I think having this feature would work same for bunch of inputs: FileInput, ImageInput, AudioInput. Looks like they need to be enum to support paths and bytes? Regarding PR: for non trivial features like this one it really helps to have a new self contained example because it becomes easy to test new feature and old examples. |
Could you accept |
Hey @nodir-t @64bit , I put up a PR which works for in-memory files ( |
hey @prosammer , thank you I was able to check it out today and it looks good given that its backward compatible change for consumers of library happy to merge it. I'll keep this issue open for the context and if someone wants to continue work on |
This seems coincidentally solve some issues for wasm support, as I was planning to do this here. Thanks @prosammer! If you have some time and interest, you can take a look at the experiment branch and help mature the wasm support. |
@ifsheldon haha awesome, I'm not very familiar with wasm but I will take a look! |
|
I am trying to understand how to upload a file with contents from memory and can't figure out how. It appears that file input is only from a file? Do I have to save my bytes to file system to read them back?
My overall goal is to upload a file my program receives, from an incoming network request to an assistant thread.
The text was updated successfully, but these errors were encountered: