Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compilation failed #183

Closed
ifsheldon opened this issue Jan 18, 2024 · 2 comments
Closed

Test compilation failed #183

ifsheldon opened this issue Jan 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ifsheldon
Copy link
Contributor

When I tried to update #125 and do a full compilation including tests, I saw this line fails to compile.

let list_files = client.files().list().await.unwrap();

The error is
image

A quick fix is

let list_files = client.files().list("").await.unwrap();

but I don't know what you want to test and I see the code came from you, so probably you can fix it yourself? @64bit

@64bit
Copy link
Owner

64bit commented Jan 18, 2024

Dang, this is my bad. yeah anything empty works including empty [] for query param.

Tests in file.rs were to test all file related APIs. I'll add fix for this.

@64bit 64bit added the bug Something isn't working label Jan 18, 2024
@64bit
Copy link
Owner

64bit commented Jan 18, 2024

This is fixed in 30f8b6a

@64bit 64bit closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants