Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple app documentation is out of date #25

Open
xtreme-sameer-vohra opened this issue Oct 17, 2024 · 1 comment
Open

Simple app documentation is out of date #25

xtreme-sameer-vohra opened this issue Oct 17, 2024 · 1 comment

Comments

@xtreme-sameer-vohra
Copy link

Readme mentions building a single docker container for which there is no Dockerfile resulting in

% docker build -t simple-reasoning-agent:latest .
[+] Building 0.1s (1/1) FINISHED                                                                                docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                            0.0s
 => => transferring dockerfile: 2B                                                                                              0.0s
ERROR: failed to solve: failed to read dockerfile: open Dockerfile: no such file or directory

Instead I believe the current workflow is

docker compose up --build
@sabbyanandan
Copy link

Hi, @xtreme-sameer-vohra! 😄

Good catch. The Dockerfile inside each [nextjs-client](https://github.com/8090-inc/xrx-sample-apps/tree/main/simple-app/nextjs-client) folder can work with this instruction, but the README is wrong in its current state. Besides, it is much better to advertise just the Docker Compose, so I agree with you.

Do you want to take a stab at cleaning this up via a PR, Sameer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants