Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for theming (text and Niagara button ) to adapt to a dynamic wallpaper, or system theme #2333

Closed
1 task done
grantsrosen opened this issue Jul 12, 2023 · 2 comments
Assignees
Labels
awaiting-response Further information is requested

Comments

@grantsrosen
Copy link

Is your feature request related to a problem?

For example, if I create a wallpaper in Kustom that is white in the daytime, and then turns dark at nighttime following my system theme (example background color formula: $if(si(darkmode)=1, #FF202125, #FFFFFFFF)$), then Niagara will theme according to the color of the wallpaper when setting, but won't adapt the theme when the color changes. So if I set the theme at night when the formula displays a dark wallpaper, the text will be white and the Niagara button will be dark. But then in the morning, when the formula changes with my system theme to display a white wallpaper, Niagara still shows white text on a now white background with a dark Niagara button. As it stands, it's not functional to use any sort of system theme adapting wallpaper with Niagara since the theming is static.

Screenshot_20230712-105053

Describe the solution you'd like

I would like options for the text and Niagara button to adapt to live wallpaper. This would bring Niagara home screens more in-line with modern android system theming for people who use live wallpapers to have a light wallpaper in daytime and a dark wallpaper at nighttime. If easier, it could potentially be coded to just refresh the theming engine specifically with the system theme. So when it detects that the system has changed theme, it refreshes the home screen theming to see if the wallpaper changed.

Feature Request Procedure

@Amorphous404
Copy link

Hi @grantsrosen, Thank you for reporting the issue. Niagara already automatically refreshes the UI, i.e., Niagara button and text color (See #2147 comment) as long as the live wallpaper is providing the correct information to the system.

The problem you are experiencing is likely caused by the KLWP app not being able to provide the information to the system or the preset not being set with the correct formulas. Could you please check if opening the preset and hitting the save button refreshes the Niagara text color?

@Amorphous404 Amorphous404 added the awaiting-response Further information is requested label Aug 2, 2023
@github-actions
Copy link

This issue has been automatically closed because there has been no response to our request for more information from the original author. Without this, we don't have enough information to help you. Please comment below with the requested information if you still need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants