Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website main page changes and added past events #178

Merged
merged 26 commits into from
Apr 13, 2024
Merged

Conversation

wjiang42
Copy link
Contributor

Added new photos for the main page, reduced background tint and added AB Underground mxmtoon and Phoebe Bridgers.

I am aware that many old files remain, and that photos in /services are unchanged.

Copy link
Member

@DaAwesomeP DaAwesomeP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing that is particularly blocking (.gitignore).

Just a small editorial note--for the images, think about who the homepage target audience is. All of these images are showing are from event and focuses on the Techies. This is great for targeting new members but maybe less so people submitting event requests for a variety of event types (dance, talent show, fashion show, corporate style, etc.) where they care more about the end result and seeing AB Tech's capabilities and "showreel" (i.e. "look at all the amazing high-production value events we do!"). Feel free to ignore me, but my recommendation would be to mix techies + cool event photos of a variety of event types.

.gitignore Outdated Show resolved Hide resolved
assets/img/carousel/astrasse.JPG Outdated Show resolved Hide resolved
assets/img/carousel/haichuas_f23.JPG Outdated Show resolved Hide resolved
assets/img/carousel/gskam_f23.JPG Outdated Show resolved Hide resolved
assets/img/carousel/esprite.JPG Outdated Show resolved Hide resolved
@wjiang42
Copy link
Contributor Author

When I was looking through drive/Photos for photos, I was mainly looking for photos taken from a proper camera (i.e. not phone camera), but I will look for some photos of more events. Thanks for the feedback!

@DaAwesomeP
Copy link
Member

When I was looking through drive/Photos for photos, I was mainly looking for photos taken from a proper camera (i.e. not phone camera), but I will look for some photos of more events. Thanks for the feedback!

TBH, the latest generations of iPhones take very good photos that I don't think anyone will be able to tell the difference. Bridget takes photos with a nicer camera (and I think she has visited a few times recently so there should be some more recent events with her photos).

@wjiang42
Copy link
Contributor Author

Personally I feel like modern phone cameras still struggle with low light environments, which is a lot of our events, so for this round of photos I only used pictures from Heidi and Bridget's cameras, but I'll start look at phone photos too.

wjiang42 and others added 3 commits February 15, 2024 12:05
This variable actually changes the transition of all Boostrap carousels, including those in abtech.org/services. I was unable to find a way to change the transition speed of the carousels by ID, so for now 1.5s is a middle ground
@wjiang42 wjiang42 requested a review from DaAwesomeP February 15, 2024 19:17
Copy link
Member

@DaAwesomeP DaAwesomeP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sorry for the delay; this one slipped through my inbox. Feel free to ping me next time.

One typo: the file concert_f23_mons.JPG has the file extension capitalized. This might actually work on Windows and macOS because I think those filesystems might not be case-sensitive, but the server uses a case-sensitive file system (as does my computer, so one image in this carousel fails for me).

One small request: In the future please split up unrelated changes into different pulls (i.e. for this pull the HoTs page and services page)

@DaAwesomeP
Copy link
Member

The repsonsive sizing on the HoTs page is not working properly now.

Before:
image

After:
image

@DaAwesomeP
Copy link
Member

DaAwesomeP commented Mar 28, 2024

The px-4 added to the layout template is also causing some smushing on mobile; you might want to make this responsive.

In general, always be sure to test on all screen sizes!

@wjiang42
Copy link
Contributor Author

Oof apologies for putting so many changes here, got lazy haha

@wjiang42 wjiang42 requested a review from DaAwesomeP March 28, 2024 01:27
_layouts/default.html Outdated Show resolved Hide resolved
@wjiang42 wjiang42 requested a review from DaAwesomeP March 28, 2024 19:32
@DaAwesomeP DaAwesomeP merged commit 82e70bb into ABTech:main Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants