Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect metadata in umfile_utils/stashvar.py #4

Open
tammasloughran opened this issue May 24, 2024 · 1 comment
Open

Incorrect metadata in umfile_utils/stashvar.py #4

tammasloughran opened this issue May 24, 2024 · 1 comment

Comments

@tammasloughran
Copy link
Contributor

ACCESS-Archiver depends on umfile_utils/stashvar.py, which has erroneous metadata for a stashvar.

The field code 3173 is soil (heterotrophic) respiration on tiles according to @rml599gh.
umfile_utils/stashvar.py has this line for code 3173:
Line 1013 atm_stashvar[3173] = ["QCF INCR: bdy layer negative", "", "", "", ""]
The model output data itself looks to me like it has values that look like soil respiration where the relevant PFTs exist, and probably isn't QCF INCR, whatever that is.

Similar to issue #2, umfile_utils is a NCI system environment module, so finding someone to change this error will be difficult.

@MartinDix
Copy link
Contributor

In the standard UM vn7.3 STASH code 3173 wasn't used, so it was grabbed for this diagnostic. From diagnostics_bl.F90

! Soil respiration on tiles (Kg C/m2/s)
! -----------------------------------------------
! Item 173 - kdcorbin, 10/10
     IF (SF(173,3)) THEN

By UM vn8.4 it'd become used for the QCF INCR field. stashvar.py was originally based on a vn10.6 STASHmaster_A file as used for CM2, so picked up this definition.

Will try to fix in ACCESS-NRI/um2nc-standalone#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants