You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue follows on from issue #100 and PR #118.
PR #118 was reduced in scope to extracting the function & adding a very basic testing framework due to project handover requirements. This issue follows up to specify unit testing requirements:
Work on this PR needs to answer & address the following:
Is the time.units.calendar == 'gregorian' code branch & testing required?
Is the time.units.calendar == 'proleptic_gregorian' code branch & testing required?
What inputs should be tested?
What outputs should be tested?
What cube state/attrs should be tested?
Is the code branch covered by test_fix_forecast_reference_time_standard() required?
Should the hardcoded 1600 for ref date year be a configurable function arg?
This issue follows on from issue #100 and PR #118.
PR #118 was reduced in scope to extracting the function & adding a very basic testing framework due to project handover requirements. This issue follows up to specify unit testing requirements:
Work on this PR needs to answer & address the following:
time.units.calendar == 'gregorian'
code branch & testing required?time.units.calendar == 'proleptic_gregorian'
code branch & testing required?test_fix_forecast_reference_time_standard()
required?1600
for ref date year be a configurable function arg?PPField.calendar
at runtime?These questions will help determine what work is required.
The text was updated successfully, but these errors were encountered: