Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which bash runner to use for entry point CI tests? #87

Open
truth-quark opened this issue Aug 22, 2024 · 0 comments
Open

Which bash runner to use for entry point CI tests? #87

truth-quark opened this issue Aug 22, 2024 · 0 comments

Comments

@truth-quark
Copy link
Collaborator

From #86, there's a suggestion regarding which bash test runner to use for um2nc entrypoints:

https://github.com/ACCESS-NRI/um2nc-standalone/blob/82/un2nc-ci-entry-test/.github/workflows/CI.yml#L96-L102

  - name: Entrypoint test of driver script
    shell: bash -l {0}
    run: esm1p5_convert_nc --help

  - name: Entrypoint test of um2netcdf script
    shell: bash -l {0}
    run: um2nc --help

@CodeGat suggested removing shell: bash -l {0} lines to use the default bash --noprofile --norc -eo pipefail {0} provided by GitHub. See https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell. It is not clear if this works with conda environments required for testing (part of the reason for using bash -l.

The first step in this task is testing if the GitHub default bash command works with conda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant