Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace discrepancies found on hardware wrst concert_description #18

Open
FraunhoferItalia opened this issue Mar 13, 2023 · 1 comment

Comments

@FraunhoferItalia
Copy link

FraunhoferItalia commented Mar 13, 2023

Hy guys!

Opening this non urgent issue with the links to the commits that include the namespace changes/discrepancies to concert_description when porting the control- as well as the navigation-ws to hardware.
You can find the neccessary changes for the control-ws here and those for the navigation-ws here.

We commited the changes on a separate branch, so let us know to which namespaces you want to stick, either those present in concert_description or those we found on the hardware.

Thanks MT

@EdoardoRomiti
Copy link
Contributor

Hi Micheal @FraunhoferItalia ,
with commit 5f4d0520bf7257e9112a2e852af7e033c2d72a85 of modular and commit 610d857 of concert_description this should be fixed. Next time on the robot you should be able to use the same namespaces as in the simulation.
Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants