Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform discrepancy in Detector checksum computation #1188

Closed
MarkusFrankATcernch opened this issue Nov 17, 2023 · 1 comment · Fixed by #1192
Closed

Platform discrepancy in Detector checksum computation #1188

MarkusFrankATcernch opened this issue Nov 17, 2023 · 1 comment · Fixed by #1192
Labels

Comments

@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Nov 17, 2023

Separate issue: Problems in checksum computation.
Was discovered here: #1184
reason: new platform build in LCG

============================================================================================
Follow up:
============================================================================================
The latest dev3 nightlies are on CVMFS: /cvmfs/sft-nightlies.cern.ch/lcg/views/dev3/latest/
============================================================================================

I think I identified 2 entries, where the problem originates:
good:

DetectorChecksum       +++ Solid     ForwardLowZ_layer1_shape_0x562b922a1660_left    0x9d4f6c7c70c3eb3e
<subtraction lunit="mm" aunit="deg">
 <first ref="0x18cb06802b07fb40">
  3695612514963747814
  9487646648968612427
 </first>
 <second ref="0xd8e9f80287ed466d">
  2554733727480708909
  13351767629364974133
 </second>
</subtraction>
DetectorChecksum       +++ Solid     ForwardLowZ_layer1_shape_0x562b922a1660    0xee0f502c9edb95a8
<subtraction lunit="mm" aunit="deg">
 <first ref="0x9d4f6c7c70c3eb3e">
  3695612514963747814
  9487646648968612427
 </first>
 <second ref="0xd77e4dd72fb4348a">
  11005821857262182534
  8140283773950079902
 </second>
</subtraction>

bad (/cvmfs/sft-nightlies.cern.ch/lcg/views/dev3/latest/):

DetectorChecksum       +++ Solid     ForwardLowZ_layer1_shape_0x4f31340_left    0x86c662618750c673
<subtraction lunit="mm" aunit="deg">
 <first ref="0x18cb06802b07fb40">
  3695612514963747814
  9487646648968612427
 </first>
 <second ref="0xd8e9f80287ed466d">
  2554733727480708909
  9487646648968612427
 </second>
</subtraction>
DetectorChecksum       +++ Solid     ForwardLowZ_layer1_shape_0x4f31340    0xcad2ed1091a6deba
<subtraction lunit="mm" aunit="deg">
 <first ref="0x86c662618750c673">
  3695612514963747814
  9487646648968612427
 </first>
 <second ref="0xd77e4dd72fb4348a">
  11005821857262182534
  9487646648968612427
 </second>
</subtraction>

Unclear is where the difference comes from.
The problem is somewhere in the hashing of the rotations. However, the rotations are clearly different
and hence the hash-code should be different.

DetectorChecksum       +++ Rotation    13351767629364974133
<rotation unit="deg" x="0.000" y="-0.010" z="0.000"/>

and:

DetectorChecksum       +++ Rotation    8140283773950079902
<rotation unit="deg" x="0.000" y="0.010" z="0.000"/>

vs.

DetectorChecksum       +++ Rotation    9487646648968612427
<rotation unit="deg" x="0.000" y="0.000" z="0.000"/>

In the bad model the two rotations are claimed to be equal....
Are we here at the end running into some precision problem?
For the conversions I have set the precision to 3 digits.
Is it possible that due to precision AND deg<->rad the "0.010" got lost ?
Using the nightly does not tell, because there the positions and rotations cannot be not dumped.

@MarkusFrankATcernch
Copy link
Contributor Author

10:59:36-frankm~/SW/DD4hep_head_dbg.root_vmaster.g4_11.00.b01_MT.G4_units/build$ cat diff.txt | grep -v "                       +++ Position"
+++ Position:   0x02fdf38a1354273a '<position unit="mm" x="0" y="0" z="-120"/>'			   <
												   >	+++ Position:   0x0be53ed0f3f3d508 '<position unit="mm" x="0" y="0" z="181"/>'
												   >	+++ Position:   0x0dc488e8706f0adc '<position unit="mm" x="0" y="0" z="51"/>'
												   >	+++ Position:   0x0f552d2174831283 '<position unit="mm" x="0" y="0" z="25"/>'
												   >	+++ Position:   0x109a47236b976c0f '<position unit="mm" x="0" y="0" z="-545"/>'
												   >	+++ Position:   0x122647140f6c1740 '<position unit="mm" x="0" y="0" z="-41"/>'
+++ Position:   0x148ec7d0f8dbeb7d '<position unit="mm" x="0" y="0" z="182"/>'			   <
+++ Position:   0x166e11e875572151 '<position unit="mm" x="0" y="0" z="52"/>'			   <
												   >	+++ Position:   0x16b8c4eebddc86f9 '<position unit="mm" x="0" y="0" z="49"/>'
+++ Position:   0x17e70d4ecc2db56b '<position unit="mm" x="0" y="0" z="610"/>'			   <
+++ Position:   0x1886df9985b446fc '<position unit="mm" x="0" y="0" z="-100"/>'			   <
+++ Position:   0x1935f02370737b88 '<position unit="mm" x="0" y="0" z="-544"/>'			   <
												   >	+++ Position:   0x1f24dae87a4a2ee2 '<position unit="mm" x="0" y="0" z="53"/>'
												   >	+++ Position:   0x1fa9364ed050faa4 '<position unit="mm" x="0" y="0" z="611"/>'
												   >	+++ Position:   0x213068998a9c5d71 '<position unit="mm" x="0" y="0" z="-103"/>'
+++ Position:   0x2566c7df978a44ea '<position unit="mm" x="0" y="0" z="248"/>'			   <
+++ Position:   0x2878282182825542 '<position unit="mm" x="0" y="0" z="26"/>'			   <
												   >	+++ Position:   0x32f3153dbf3db5e7 '<position unit="mm" x="0" y="0" z="-97"/>'
												   >	+++ Position:   0x336aba9995312537 '<position unit="mm" x="0" y="0" z="-105"/>'
+++ Position:   0x3ab51e3dc360c4c0 '<position unit="mm" x="0" y="0" z="-96"/>'			   <
												   >	+++ Position:   0x3af8a6dd6d3e3f7b '<position unit="mm" x="0" y="0" z="-181"/>'
												   >	+++ Position:   0x4c909f0b132b4f03 '<position unit="mm" x="0" y="0" z="-31"/>'
+++ Position:   0x4e35b8254ae3df3b '<position unit="mm" x="0" y="0" z="-62"/>'			   <
+++ Position:   0x541ba1dd7b3d823a '<position unit="mm" x="0" y="0" z="-182"/>'			   <
												   >	+++ Position:   0x55d9fd0918a64844 '<position unit="mm" x="0" y="0" z="15"/>'
+++ Position:   0x595f8595d86b75ec '<position unit="mm" x="0" y="0" z="116"/>'			   <
+++ Position:   0x5ea18a2553ef7149 '<position unit="mm" x="0" y="0" z="-60"/>'			   <
												   >	+++ Position:   0x62e24e95de0be9e1 '<position unit="mm" x="0" y="0" z="115"/>'
												   >	+++ Position:   0x728258dfc2f8fe87 '<position unit="mm" x="0" y="0" z="247"/>'
												   >	+++ Position:   0x7bfb38823d7e2a94 '<position unit="mm" x="0" y="0" z="-247"/>'
+++ Position:   0x858b2834d02b5831 '<position unit="mm" x="0" y="0" z="-82"/>'			   <
												   >	+++ Position:   0x8655e4d42df36ef9 '<position unit="mm" x="0" y="0" z="313"/>'
+++ Position:   0x8ebce0021b0d5f3f '<position unit="mm" x="0" y="0" z="-22"/>'			   <
												   >	+++ Position:   0x967f89021f317df8 '<position unit="mm" x="0" y="0" z="-23"/>'
+++ Position:   0x99a45e007b829ff7 '<position unit="mm" x="0" y="0" z="478"/>'			   <
+++ Position:   0xa0525fd43cab7bf8 '<position unit="mm" x="0" y="0" z="314"/>'			   <
												   >	+++ Position:   0xa2402700805ee5d0 '<position unit="mm" x="0" y="0" z="479"/>'
												   >	+++ Position:   0xb0f3fd15e22d397f '<position unit="mm" x="0" y="0" z="-413"/>'
+++ Position:   0xb66f818cefca2e03 '<position unit="mm" x="0" y="0" z="104"/>'			   <
+++ Position:   0xb8b6a615e6515838 '<position unit="mm" x="0" y="0" z="-412"/>'			   <
												   >	+++ Position:   0xbcf1e90952ccd880 '<position unit="mm" x="0" y="0" z="19"/>'
												   >	+++ Position:   0xc878c0e8492f30b4 '<position unit="mm" x="0" y="0" z="59"/>'
												   >	+++ Position:   0xd88144d1e62a3f62 '<position unit="mm" x="0" y="0" z="-313"/>'
+++ Position:   0xe0514dd1ea598b97 '<position unit="mm" x="0" y="0" z="-314"/>'			   <
+++ Position:   0xe424043d925c8e4a '<position unit="mm" x="0" y="0" z="-98"/>'			   <
+++ Position:   0xec96ad827d467505 '<position unit="mm" x="0" y="0" z="-248"/>'			   <
+++ Position:   0xed0717ef004e27c7 '<position unit="mm" x="0" y="0" z="412"/>'			   <
+++ Position:   0xedc4d60e7d1b4eab '<position unit="mm" x="0" y="0" z="544"/>'			   <
												   >	+++ Position:   0xf029d2764a53d243 '<position unit="mm" x="0" y="0" z="-611"/>'
												   >	+++ Position:   0xf122ab06a01885f3 '<position unit="mm" x="0" y="0" z="-479"/>'
												   >	+++ Position:   0xf238208d1168f116 '<position unit="mm" x="0" y="0" z="103"/>'
												   >	+++ Position:   0xf586ff0e813e93e4 '<position unit="mm" x="0" y="0" z="545"/>'
												   >	+++ Position:   0xf67ca0ef05e3a4a0 '<position unit="mm" x="0" y="0" z="413"/>'
+++ Position:   0xf7ebfb764e77177c '<position unit="mm" x="0" y="0" z="-610"/>'			   <
+++ Position:   0xf9bed406a4f56eec '<position unit="mm" x="0" y="0" z="-478"/>'			   <

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant