-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bonsai reconstruction crashes on an event generated by ratpac #111
Comments
Bonsai requires at least 4 hit for any realistic fit to be made. There used to be a condition that required at least 4 nhits prior to dark noise before. This seemed to have been taken out. It was added recently with a requirement of 9 nhits. This has not yet been ported to the version of rat-pac within Watchman. |
Based on conversations with the DAQ group, a detector threshold of 6 nhits is realistic. There are two potential approach here:
For the second option:
Finally, @katfra noticed that reconstruction from the bonsai version in rat-pac has much poorer reconstructions than the bonsai standalone. From my understanding, this was not completly explained by the change of likelihood. |
@MarcFBergevin, thanks for looking at this issue. For now, does that mean it is recommended to use the HEAD version from: https://github.com/AIT-WATCHMAN/bonsai/ ? On this particular issue, I may be misunderstanding, but in this case, the crashing event has The segfault happens on the line:
Since So, naively, it seems like a bug in BONSAI and that the correct action is to modify BONSAI to check that the |
The version of BONSAI included within rat-pac crashes on the first event of the attached file.
example_problematic_ratpac_file.zip
The RAT-PAC macro to generate this file is:
Inspecting the crash inside gdb the issue seems to be because inside fourhitgrid::fourhitgrid only 3 hits are selected. This leads to a seg fault since this grid object is used without checking that it is in a valid state.
I don't understand the reconstruction enough to know whether this is due to invalid input data that the reconstruction should not be expected to handle, or whether this is a valid input and the problem is in bonsai.
The text was updated successfully, but these errors were encountered: