Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup - sorted imports and python code style guides #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xidus90
Copy link
Contributor

@xidus90 xidus90 commented Aug 29, 2023

Hey I added tox to the project and added isort and flake8/pep8.

Isort will sort all import in a standard format.
flake8/pep8 add a python code style guide.

To run the text you need to install tox pip install tox
Then run it with tox will run isort and pep8

Examples:

  • imports sorted
  • max line length to 120
  • fixed wrong intends
  • delete too many blank lines
  • added many f-stings
  • added some switch/case
  • and more

@AIrjen
Copy link
Owner

AIrjen commented Aug 30, 2023

Hi! Thank you, this is very interesting. As you can tell, I’m not a software developer 😅
Reading up on pep8 and yes, would be good to use industry standards. Already know a lot of places which could use a proper rewrite. Learning on the go ☺️

I am hesitant to merge this right now. I currently don’t have computer access. Just my phone. Meaning that I have no way to test or fix things after merging. You mention it changes stuff to use switch statements. I had to remove those at the start of the project due to python environment differences of the users.

I am all for yolo’ing stuff to prod, but I’d like to be there when stuff fails to quickly pick up the issues. Especially when the changes are this huge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants