Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALiVE_SYS_LOGISTICS_CARRYABLE - Review #704

Open
trapw0w opened this issue Jun 3, 2020 · 2 comments
Open

ALiVE_SYS_LOGISTICS_CARRYABLE - Review #704

trapw0w opened this issue Jun 3, 2020 · 2 comments

Comments

@trapw0w
Copy link
Contributor

trapw0w commented Jun 3, 2020

Opening a ticket to review the ability to Whitelist carryable items. At the moment, Whitelist is defined but cannot be set as no module represents ALiVE_SYS_LOGISTICS & this cannot be directly modified from within the mission file due to current order of operations.

Possible Solutions:

  • Relax default allow list (e.g. include "Object" or something similar)
  • Add a custom suffix (e.g. ALiVE_SYS_LOGISTICS_CARRYABLE_CUST) that is appended to ALiVE_SYS_LOGISTICS_CARRYABLE on the addAction case.
  • Add a whitelist input onto an ALiVE Module, similarly to how the Blacklist is currently done.

Points of interest:

GVAR(CARRYABLE) = [["Man"],["Reammobox_F","Static","StaticWeapon","ThingX","NonStrategic"] + (_logic getvariable ["WHITELIST",[]]),["House"] + (_logic getvariable ["BLACKLIST",[]])];

case ("carryObject") : {

@friznit
Copy link
Contributor

friznit commented Jun 4, 2020

Relaxing the default allow list may have unintended consequences unless it's possible to target specific groups of items by size or weight?

The current player log module is by exclusion - place module and sync items you want to exclude from logistics. We could add a separate logistics enabler module - sync objects to it that you want to include in player logistics.

And include the equivalent var to ALiVE_SYS_LOGISTICS_DISABLE, so you could put this setvariable ["ALiVE_SYS_LOGISTICS_ENABLE",true] in an editor object.

@trapw0w
Copy link
Contributor Author

trapw0w commented Jun 5, 2020

@friznit Happy with that. Only question I'd have is which list (blacklist/whitelist) do you treat as priority? E.g. If I have a class set in the whitelist that is also defined in the blacklist, which would we favour?

Similar issue with specifics, e.g. typeOf "House" is in the blacklist by default, what If I want to add a classname to the whitelist that would also return true for typeOf "House", e.g: Land_PortableLight_double_F?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants