Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEV-SNP: Invalid parameter 'certs-path' #237

Open
kimullaa opened this issue Sep 27, 2024 · 3 comments
Open

SEV-SNP: Invalid parameter 'certs-path' #237

kimullaa opened this issue Sep 27, 2024 · 3 comments

Comments

@kimullaa
Copy link

When I specified the --certs option with launch-qemu.sh, it failed with the message: Invalid parameter: certs-path'.

$ sudo ./launch-qemu.sh -hda "../ubuntu1.qcow2" -sev-snp -certs /opt/snp/cert_chain.cert
...
qemu-system-x86_64: -object sev-snp-guest,id=sev0,policy=0xb0000,cbitpos=51,reduced-phys-bits=1,certs-path=/opt/snp/cert_chain.cert: Invalid parameter 'certs-path'

I checked the target/i386/sev.c file in the snp-latest branch of AMDESE/qemu, but it doesn't seem to accept a certs-path option.https://github.com/AMDESE/qemu/blob/snp-latest/target/i386/sev.c#L2410-L2430

I think we probably need to apply the patch from this commit to the snp-latest branch.

@tlendacky
Copy link
Collaborator

Upstream is still ironing out the interface for this, so an extended guest request in the kernel will not return any certificates at this time and Qemu did not incorporate the certificate related arguments. That should all be worked out soon, hopefully.

@kimullaa
Copy link
Author

kimullaa commented Sep 27, 2024

Thank you for your response!

It seems misleading to include an option in launch-qemu.sh that always results in failure. Do you think it's ok since it's only temporary?

@tlendacky
Copy link
Collaborator

Probably just an oversight on our part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants